Kevin Southworth

The DotNetNuke ListController is Slooooow

Fri, 07 May 2010 01:15:55 -0400

In one of our custom DNN modules we are grabbing the list of Countries and Regions for each Country for the DotNetNuke Host List. This is normally a good thing since we then have a standardized list of Countries/Regions, and it also allows the DNN Site Administrator to add new Countries and/or Regions to the list and have them show up automatically in our module.

The problem is that the DNN ListController API seems to be very slow when dealing with larger sets of Countries and Regions. A customer of ours had customized their list to include many more countries, and many more regions for each country. All of a sudden our module slowed to a crawl!

I ran the RedGate ANTS profiler on the code and found the “GetListEntryInfoCollection()” method on the “ListController” DNN class was taking almost 4 seconds to execute!!

I ended up writing my own helper method to retrieve the same list in under 0.5 seconds. This may not be a best practice, since my function is calling straight SQL through ADO.Net, but it’s definitely faster to execute!

The relevant code snippets are below.

——————————————————————-

        internal static List GetCountryListAdoNet()
        {
            string sql = string.Format(@"
                SELECT
                country.Value as CountryCode
                ,country.[Text] as CountryName
                ,region.Value as RegionCode
                ,region.[Text] as RegionName
                FROM {0}Lists country
                LEFT JOIN {0}Lists region ON country.EntryID = region.ParentID
                WHERE country.ListName = 'Country'
                --ORDER BY country.[Text], region.[Text]
            ", GetDbObjectQualifier() ?? "");

            Dictionary countries = new Dictionary();

            using (IDataReader reader = DotNetNuke.Data.DataProvider.Instance().ExecuteSQL(sql))
            {
                while (reader.Read())
                {
                    string countryCode = reader.GetString(0);
                    string countryName = reader.GetString(1);

                    CountryInfo country;
                    if(!countries.TryGetValue(countryCode, out country))   
                    {
                        country = new CountryInfo() { CountryCode = countryCode, Name = countryName };
                        countries[countryCode] = country;
                    }

                    if (!reader.IsDBNull(2) && !reader.IsDBNull(3))
                    {
                        country.Regions.Add(reader.GetString(3), new RegionInfo() { RegionCode = reader.GetString(2), Name = reader.GetString(3) });
                        //country.Regions.Add(new RegionInfo() { RegionCode = reader.GetString(2), Name = reader.GetString(3) });
                    }
                }
            }

            var list = countries.Values.ToList();
            list.Sort((left, right) => left.Name.CompareTo(right.Name));

            return list;
        }

    internal class CountryInfo
    {
        public string CountryCode { get; set; }
        public string Name { get; set; }
        public SortedList Regions { get; set; }

        public CountryInfo()
        {
            Regions = new SortedList();
        }
    }

    internal class RegionInfo
    {
        public string RegionCode { get; set; }
        public string Name { get; set; }
    }

Installing DNN 5.3.1

Thu, 25 Mar 2010 10:06:28 -0400

Let’s see how this goes, excited to try the new taxonomy and user profile features

Why DNN object qualifiers are a pain in the butt!

Wed, 24 Mar 2010 13:53:42 -0400

Why DNN object qualifiers are a pain in the butt!

Web Ascender launches Product Division: www.DNNspot.com

Mon, 15 Mar 2010 23:22:49 -0400

After a lot of hard work, we (Web Ascender) have launched a brand new Product Division: www.DNNspot.com ! DNNspot provides pre-packaged modules for the popular DotNetNuke content management system. Some of our current modules that are available now:

Online Store and Shopping Cart
Content Rotator to display photo and content slide shows
Live Support / Live Agent Chat
Referral Tracker (see where your visitors came from)
Sitemap

We plan to add more modules in the future, but for now, congratulations to the team for all their hard work!

geek if you’re looking for a good .NET component to read excel files, check out gembox...

Thu, 04 Feb 2010 22:31:44 -0500

geek if you’re looking for a good .NET component to read excel files, check out gembox software

Web Ascender announces product division

Wed, 20 Jan 2010 10:49:48 -0500

Web Ascender announces product division

Just installed Chrome Beta and a delicious extension, feels great to finally have extensions in...

Wed, 13 Jan 2010 10:07:39 -0500

Just installed Chrome Beta and a delicious extension, feels great to finally have extensions in chrome

I’m attending CodeMash 2010

Thu, 07 Jan 2010 15:25:11 -0500

I’m attending CodeMash 2010

New Year's Resolutions

Sat, 02 Jan 2010 13:33:48 -0500

Eat healthier (breakfast every day, cut fast food to twice/wk max, bring lunches, plan dinners each week)
Work out at least 4 days/wk
Learn a new computer language (Ruby on Rails)

Nifty tool for checking/validation your website for SEO and Performance optimizations

Wed, 16 Dec 2009 14:58:36 -0500

Nifty tool for checking/validation your website for SEO and Performance optimizations

Michigan will be smoke fee on May 1st !

Fri, 11 Dec 2009 10:33:17 -0500

Michigan will be smoke fee on May 1st !

Pretty sweet Visual Studio Add-In for customized build numbers

Thu, 10 Dec 2009 00:00:36 -0500

Pretty sweet Visual Studio Add-In for customized build numbers

Tasty dinner at Tomato Bros in Howell :)

Sun, 06 Dec 2009 19:56:10 -0500

Tasty dinner at Tomato Bros in Howell :)

At the MSU game

Fri, 04 Dec 2009 19:36:41 -0500

At the MSU game

Excited for the MSU game tonight with Angie, should be a W

Fri, 04 Dec 2009 07:14:32 -0500

Excited for the MSU game tonight with Angie, should be a W